On Fri, Feb 6, 2009 at 3:54 PM, Margie <margierogin...@yahoo.com> wrote:
>
> Hi,
>
> I was searching for a way to add a class to messages that are created
> via user.message_set.create(message="my message here").  I found a
> number of people discussing this and found what seems to be patch that
> does just what I want:
>
>
> http://code.djangoproject.com/attachment/ticket/3995/3995.django.contrib.auth.diff
>
> However, after downloading the django source via:
>
> svn co http://code.djangoproject.com/svn/django/trunk/
>
> I don't see that patch in place.  This is my first time getting source
> rather than using the release.  How would I find out what the status
> of this is?  Perhaps I am not really seeing top of trunk?
>

The status is in the ticket:

http://code.djangoproject.com/ticket/3995

Up near the top it says (new) not (fixed) so it's still an open ticket, and
no fix has been put into the codebase for this yet.

When the code in svn is updated to include a fix, the status will be changed
to fixed, and there will be a comment added that notes what changeset made
the fix.  Something like this:

http://code.djangoproject.com/ticket/10187#comment:3

Only after you see something like that in your ticket of interest would
pulling the latest SVN trunk code get you a version with the fix already
integrated.

If you want to run with the patch currently on the ticket, you'll need to
apply it to your checked-out copy of the source tree, using the patch
command.  However, I'd be a bit cautious about applying that particular
patch.

First, it is fairly old so unlikely to apply cleanly (patch can handle some
amount of code movement due to the base tree changing over time, but that
patch is over a year old and given how much the Django code base has changed
since Dec. 2007 I'd be surprised if that patch applies cleanly).

Second, that patch adds a column to one of the auth tables, so is going to
cause problems if you try to use it with a pre-existing (already ran syncdb)
installation that doesn't have that new column.  If you're intending to use
the patch only with new installs, or know how to manually update your
existing auth table to add the new column, then you're OK, but running that
code on an existing Django project without fixing up the existing auth table
is going to result in errors.

[Side note: This need to add a column to an existing auth table is likely
one reason why this ticket has not  been integrated.  As Jacob notes in one
of the comments in the ticket, a transition plan is needed to handle
upgrading existing tables, and I don't see that that was addressed at all.]

Karen

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to 
django-users+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to