On Wed, 2009-01-28 at 21:26 -0800, Jason Geiger wrote:
> Hello all. The docs say about QuerySet.create [1]:
> """
> This is equivalent to (but much simpler than):
>
> >>> b = Blog.objects.get(id=1)
> >>> e = Entry(
> .... blog=b,
> .... headline='Hello',
> .... body_text='Hi',
> .... pub_date=datetime.date(2005, 1, 1)
> .... )
> >>> e.save()
> """
>
> I was trying to use create() with list of dicts representing rows that
> may or may not exist yet (some have ids and some don't) and hoping to
> get the insert-or-update behavior of save() [2].
>
> Unfortunately (for me) it looks like QuerySet.create() passes
> force_insert=True [3].
Right. It's called "create", after all, so creating a new instance
hopefully isn't massively unintuitive behaviour, as you observe. :-)
>
> It's entirely sane that a method called create() would only do
> inserts. If that's the case, the doc can be updated to reflect that,
Sure. Open a ticket and attach a patch to update the docs and we'll
commit it at some point. You're right that we should update the docs.
> and ... would anyone else find it useful to have a method on QuerySet
> that behaves the way I thought create() did? Something like
> QuerySet.save(**kw)?
Not really worth it. It's not really a method on querysets, after all
(it is, technically, but that's only an API hook). It's a method on the
model manager, describing a way to do something to a model class. It's a
way to create or save model instances. Having to do the save() call on
the next line isn't really going to overly burden your code. I'd be
against adding Yet Another Method.
Still, if the extra line of code will really set you back each time,
here you go:
def maybe_create_or_maybe_update(model, **kwargs):
obj = model(**kwargs)
obj.save()
return obj
Regards,
Malcolm
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to
django-users+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
