On Fri, 2009-01-16 at 11:19 +0100, Thomas Guettler wrote: > Hi, > > I think it is bad that request.session.save() is called, if > the DEBUG-View gets returned on an uncaught exception. > > I looked at the django source, but could not find a good patch for django > or my code. > > What is bad about this: The debug view is not returned, since a second > happens > on request.session.save():
> [...] > Has someone a hint how to fix this? If we were to handle this, we'd essentially have to say that no middleware responses should run if we're handling an uncaught exception (which would require code changes, but obviously isn't impossible). Unclear if the downsides of that outweigh the benefits. It would be a little silly just to special-case session saving, since (a) it is actually only valid when you've had some kind of database error; many errors won't raise this problem, and (b) session.save() isn't the only middleware that might talk to the database or filesystem or whatever. My intuition is that we probably shouldn't run middleware responses, for the same reason we don't run context processors in the uncaught exceptions: anything could be broken. But that's a semi-intrusive change, so you should probably bring it up on django-dev. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to django-users+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
