On Mon, 2008-11-17 at 11:53 -0800, Peter wrote: > When I run django admin and do startproject I get a settings file that > has: > > MIDDLEWARE_CLASSES = ( > 'django.middleware.common.CommonMiddleware', > 'django.contrib.sessions.middleware.SessionMiddleware', > 'django.contrib.auth.middleware.AuthenticationMiddleware', > ) > > In the global_settings.py file there is: > > # List of middleware classes to use. Order is important; in the > request phase, > # this middleware classes will be applied in the order given, and in > the > # response phase the middleware will be applied in reverse order. > > MIDDLEWARE_CLASSES = ( > 'django.contrib.sessions.middleware.SessionMiddleware', > 'django.contrib.auth.middleware.AuthenticationMiddleware', > # 'django.middleware.http.ConditionalGetMiddleware', > # 'django.middleware.gzip.GZipMiddleware', > 'django.middleware.common.CommonMiddleware', > ) > > Order is declared to be important so which is the correct order?
Good catch. Fortunately, in this case it doesn't really matter. The version in global_settings is very slightly less efficient, but the work done by session and auth middlewares is reasonably independent to what the common middleware does. The reason the latter version is less efficient is because if the common middleware needs to make a redirect due to adding a trailing slash or something like that, there's really no need to have gone through the session and authentication process. I guess there's possibly some odd-looking setup possible where authentication fails on the passed in URL but passes on the version common middleware redirects to and thus the first order is more accurate for that reason, but it would be an unlikely situation. In any case, if you would be kind enough to open a ticket for this, we'll switch around the global version to be consistent. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
