Bruno, Thanks, this helps a lot. > > > While we're at it : what's your use case for adding the domain name to > > > the url ? > > > I'm doing this in a custom tag to produce a sidebar menu of recent > > posts. > > Recent posts belonging to the same site ? I assume so, since you use > sites.objects.get_current(). Then why do you want to add the domain > name ? This will JustWork(tm) without, you know ?-) > > Just use get_absolute_url(), and things will be fine. You are right, it wasn't necessary to add the domain name explicitly. I had only done this because of some earlier issues with flatpage URLs (where it was necessary to add the domain name).
> Slightly OT, but may I suggest a couple improvements ? > > 1/ if pages is empty, you'll end up with "<ul></ul>", which is invalid > markup. You should test for pages and return an empty string if empty. > > 2/ use Python's string formating and idioms. The idiomatic Python code > would be: > > def entries_index(): > pages = Entry.objects.all()[:5] > if not pages: > return '' > tpl = '<li><a href="%s" title="%s">%s</a></li>" > entries = [ > li % (page.get_absolute_url(), page.title, page.title) > for page in pages > ] > return "\n".join(['<ul>'] + entries + ['</ul>']) > > note that the markup might break if there's a double-quote in > page.title... You should escape any char that is unsafe within an html > tag attribute. But anyway: Yes, I need to look at the Python way. But I notice that Django examples on the web (and in books) are not very consistent on such things. > 3/ may I suggest using a template instead of hard-coding html in your > Python code? So you don't have to edit code to modify the generated > markup? Yes, I'm just seeing how this might be a better idea. Thanks again. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
