On 7 sep, 18:57, AmanKow <[EMAIL PROTECTED]> wrote: > Monkey patching attributes to the instances would not be the correct > django idiom for adding a calculated field.
Depends on what is computed, and what this computation depends on. You're of course right that it's better to put strictly model related stuff in the model. Now there are a lot of cases where what is computed is mostly presentation-related - specially when using a template system that doesn't allow any computation - and possibly depends on the request / session data. IOW : While you're right to mention that it's better to move model- related stuff where it belongs whenever possible (and the "notice" is welcome - I should indeed have mentioned this myself), asserting that dynamically adding instance attributes on the fly to a model instance within the view is not *the* "correct" idiom is way too dogmatic. Also and FWIW, "monkey-patch" usually denotes modification of classes and/or modules of a third-part lib. Dynamically adding instance attributes from within the same lib / application, while not to be used with no good reasons, is a perfectly valid and somewhat common Python idiom. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
