On 11/10/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > Was it intended to change the type of the 'classes' value in an Admin field > (now fieldset in newforms-admin) specification from string to tuple? The > old doc here: > > http://www.djangoproject.com/documentation/model-api/#classes > > states the value should be a string and if you want to specify more than one > class separate them with spaces. The new code here: > > http://code.djangoproject.com/browser/django/branches/newforms-admin/django/contrib/admin/options.py#L72 > > is clearly expecting a tuple, not a string. You can pass a string in, but > the effect of the init code is to insert spaces between all the characters, > resulting in a quiet failure to do anything useful with an old-style spec. > The change in type means you cannot just cut-and-paste your old fields > specifications (simply renamed to fieldsets) from your old code to the new > way when migrating to newforms-admin. I don't see mention of this backwards > incompatibility on the newforms-admin branch page, so I am wondering if it > was a mistake? Basically I'm wondering if I should change my code to > specify a tuple or open a ticket and supply a patch to newforms-admin to > make it accept strings here ala old admin?
Yes, it was intentional, but I don't feel particularly strong about the change. I don't think that backwards compatibility is a good reason to keep it the same as so many other things are changing anyhow. That said, it should be documented on the newforms-admin wiki page, and I apologize for not doing so. Would you mind updating the wiki or starting a thread on the dev list if you'd like to see the change reversed? Thanks, Joseph --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-users?hl=en -~----------~----~----~----~------~----~------~--~---
