Hello
I am having two problems with the attached code (which I have drawn
heavily from the post 'Newforms practice (common situation)') and
would appreciate any advice on how to fix it as I am going round in
circles.
1) When I add a survey (before entering or saving any data), the form
appears OK but is giving me validation errors for the required fields
2) When I edit an existing survey, the form with the instance data
comes up fine, but when I try to save it, I get a TypeError -
'SurveyForm' object is not callable. When debugging everything seems
fine until it gets to form = InstanceForm(request.POST), when this
error occurs. instance seems to hold the correct data as does
InstanceForm.
In the above mentioned posting, Felix says that __dict__ won't work
properly for Foreign keys and it is better to pass the instance into
the form and hence my adaptation of his code. I am using custom forms
here to learn how to use them but also as I will need to incorporate a
bit more logic at a later data.
Thanks in advance
Cat
models.py
class Survey(models.Model):
survey_type = models.ForeignKey(SurveyType, null = True, blank =
True)
associated_company = models.ForeignKey(Company, null = False,
blank = False)
operator = models.ForeignKey(Operator, null = True, blank = True)
contractor = models.ForeignKey(Contractor, null = True, blank =
True)
vessel = models.ForeignKey(Vessel, null = True, blank = True)
survey_name = models.CharField(max_length = 50, null = False,
blank = False)
location = models.CharField(max_length = 30, null = False, blank =
False)
start_date = models.DateField(null = False, blank = False)
end_date = models.DateField(null = True, blank = True)
notes = models.TextField(null = True, blank = True)
created_by = models.ForeignKey(User, related_name =
"survey_created_by", null = False, blank = False)
created_date = models.DateTimeField(null = False, blank = False)
last_modified_by = models.ForeignKey(User, related_name =
"survey_last_modified_by", null = False, blank = False)
last_modified_date = models.DateTimeField(null = False, blank =
False)
def save(self):
if self.id is None:
self.created_by_id = self.last_modified_by_id =
int(threadlocals.get_current_user().id)
self.created_date = self.last_modified_date =
datetime.now()
else:
self.last_modified_by_id =
int(threadlocals.get_current_user().id)
self.last_modified_date = datetime.now()
super(Survey,self).save()
class Meta:
verbose_name_plural = "surveys"
db_table = "Survey"
ordering = ['start_date']
class Admin:
pass
def __unicode__(self):
return self.survey_name
forms.py
class SurveyForm(forms.Form):
survey_name = forms.CharField(required = True)
associated_company_id = forms.ModelChoiceField(queryset =
Company.objects.all(), required = True)
operator_id = forms.ModelChoiceField(queryset =
Operator.objects.all(), required = False)
contractor_id = forms.ModelChoiceField(queryset =
Contractor.objects.all(), required = False)
vessel_id = forms.ModelChoiceField(queryset =
Vessel.objects.all(), required = False)
survey_type_id = forms.ModelChoiceField(queryset =
SurveyType.objects.all(), required = True)
location = forms.CharField(required = True)
start_date = forms.DateField(required = True)
end_date = forms.DateField(required = False)
notes = forms.CharField(widget = forms.Textarea(), required =
False)
def __init__(self, data = None, auto_id = 'id_%s', prefix = None,
initial = None, instance = None):
if instance is not None:
self.instance = instance
new_data = {}
new_data = {'survey_type_id': instance.survey_type_id,
'associated_company_id': instance.associated_company_id,
'operator_id': instance.operator_id, 'contractor_id':
instance.contractor_id, 'vessel_id': instance.vessel_id,
'survey_name': instance.survey_name, 'location': instance.location,
'start_date': instance.start_date, 'end_date': instance.end_date,
'notes': instance.notes}
data = new_data
else:
self.instance = None
super(SurveyForm, self).__init__(data, auto_id, prefix,
initial)
def save(self, commit = True):
if self.instance is not None:
instance = self.instance
else:
instance = Survey()
instance.survey_type_id =
self.cleaned_data['survey_type_id']
instance.associated_company_id =
self.cleaned_data['associated_company_id']
instance.operator_id = self.cleaned_data['operator_id']
instance.contractor_id =
self.cleaned_data['contractor_id']
instance.vessel_id = self.cleaned_data['vessel_id']
instance.survey_name = self.cleaned_data['survey_name']
instance.location = self.cleaned_data['location']
instance.start_date = self.cleaned_data['start_date']
instance.end_date = self.cleaned_data['end_date']
if commit:
instance.save()
return instance
views.py
def addEditSurvey(request, id = None):
if id is not None:
instance = Survey.objects.get(id=id)
InstanceForm = SurveyForm(instance = instance)
else:
InstanceForm = SurveyForm()
if request.method == 'POST':
form = InstanceForm(request.POST)
if form.is_valid():
form.save()
return HttpResponseRedirect("/event/survey")
return render_to_response('add_edit_survey.html', {'form':
InstanceForm})
The POST data is
contractor_id u'1'
operator_id u'1'
end_date u''
notes u''
survey_name u'Test'
start_date u'2003-01-02'
location u'latrobe'
associated_company_id u'1'
survey_type_id u'3'
vessel_id u'1'
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
