I have attached my first try at a django patch (based of course on the
patches in the tracker). It adds support for BigIntegerField (but not
PositiveBigIntegerField) and should work on MSSQL, Oracle, MySQL, SQLite and
Postgresql.
Can everyone please have a look at this and see if I have made any mistakes?
Thanks
Peter
On Tue 10 Jul 2007, Collin Grady wrote:
> Mentioned this on IRC, but just for the record here as well: It's
> likely that the patch wouldn't be applied so long as it affects only
> one backend - fields have to be consistent across all of them (partial
> is /not/ better in cases like that). :)
>
> On Jul 9, 1:47 pm, Peter Nixon <[EMAIL PROTECTED]> wrote:
> > Hi Guys
> >
> > I am a relative newcommer to the Django world (a couple of months), so
> > this is my first post to the list. Let me first say how quickly I fell
> > in love with the power and flexibility of Django. Keep up the good work.
> >
> > I have a question however. While trying to interface with an existing
> > SQL table I stumbled across the problem that Django doesn't currently
> > support BIGINT field types. I managed to track down a ticket in the
> > tracker which has been open for for 2 year which appears to fix this
> > problem:
> >
> > http://code.djangoproject.com/ticket/399
> >
> > Is there any reason why this patch has not been applied in one form or
> > another? Partial/imperfect support for BIGINT would IMHO be better than
> > nothing..
--
Peter Nixon
http://www.peternixon.net/
PGP Key: http://www.peternixon.net/public.asc
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
Index: django/oldforms/__init__.py
===================================================================
--- django/oldforms/__init__.py (revision 5637)
+++ django/oldforms/__init__.py (working copy)
@@ -759,6 +759,14 @@
if not 0 <= int(field_data) <= 32767:
raise validators.CriticalValidationError, ugettext("Enter a whole number between 0 and 32,767.")
+class BigIntegerField(IntegerField):
+ def __init__(self, field_name, length=20, maxlength=None, is_required=False, validator_list=None, member_name=None):
+ if validator_list is None: validator_list = []
+ validator_list = [self.isInteger] + validator_list
+ if member_name is not None:
+ self.member_name = member_name
+ IntegerField.__init__(self, field_name, length, maxlength, is_required, validator_list)
+
class FloatField(TextField):
def __init__(self, field_name, is_required=False, validator_list=None):
if validator_list is None: validator_list = []
Index: django/db/models/fields/__init__.py
===================================================================
--- django/db/models/fields/__init__.py (revision 5637)
+++ django/db/models/fields/__init__.py (working copy)
@@ -800,6 +800,10 @@
defaults.update(kwargs)
return super(IntegerField, self).formfield(**defaults)
+class BigIntegerField(IntegerField):
+ def get_manipulator_field_objs(self):
+ return [oldforms.BigIntegerField]
+
class IPAddressField(Field):
empty_strings_allowed = False
def __init__(self, *args, **kwargs):
Index: django/db/backends/ado_mssql/creation.py
===================================================================
--- django/db/backends/ado_mssql/creation.py (revision 5637)
+++ django/db/backends/ado_mssql/creation.py (working copy)
@@ -11,6 +11,7 @@
'FloatField': 'double precision',
'ImageField': 'varchar(100)',
'IntegerField': 'int',
+ 'BigIntegerField': 'bigint',
'IPAddressField': 'char(15)',
'ManyToManyField': None,
'NullBooleanField': 'bit',
Index: django/db/backends/postgresql/introspection.py
===================================================================
--- django/db/backends/postgresql/introspection.py (revision 5637)
+++ django/db/backends/postgresql/introspection.py (working copy)
@@ -69,6 +69,7 @@
# Maps type codes to Django Field types.
DATA_TYPES_REVERSE = {
16: 'BooleanField',
+ 20: 'BigIntegerField',
21: 'SmallIntegerField',
23: 'IntegerField',
25: 'TextField',
Index: django/db/backends/postgresql/creation.py
===================================================================
--- django/db/backends/postgresql/creation.py (revision 5637)
+++ django/db/backends/postgresql/creation.py (working copy)
@@ -15,6 +15,7 @@
'FloatField': 'double precision',
'ImageField': 'varchar(100)',
'IntegerField': 'integer',
+ 'BigIntegerField': 'bigint',
'IPAddressField': 'inet',
'ManyToManyField': None,
'NullBooleanField': 'boolean',
Index: django/db/backends/sqlite3/introspection.py
===================================================================
--- django/db/backends/sqlite3/introspection.py (revision 5637)
+++ django/db/backends/sqlite3/introspection.py (working copy)
@@ -62,6 +62,7 @@
'smallinteger': 'SmallIntegerField',
'int': 'IntegerField',
'integer': 'IntegerField',
+ 'bigint': 'BigIntegerField',
'text': 'TextField',
'char': 'CharField',
'date': 'DateField',
Index: django/db/backends/sqlite3/creation.py
===================================================================
--- django/db/backends/sqlite3/creation.py (revision 5637)
+++ django/db/backends/sqlite3/creation.py (working copy)
@@ -14,6 +14,7 @@
'FloatField': 'real',
'ImageField': 'varchar(100)',
'IntegerField': 'integer',
+ 'BigIntegerField': 'bigint',
'IPAddressField': 'char(15)',
'ManyToManyField': None,
'NullBooleanField': 'bool',
Index: django/db/backends/mysql/introspection.py
===================================================================
--- django/db/backends/mysql/introspection.py (revision 5637)
+++ django/db/backends/mysql/introspection.py (working copy)
@@ -83,7 +83,7 @@
FIELD_TYPE.FLOAT: 'FloatField',
FIELD_TYPE.INT24: 'IntegerField',
FIELD_TYPE.LONG: 'IntegerField',
- FIELD_TYPE.LONGLONG: 'IntegerField',
+ FIELD_TYPE.LONGLONG: 'BigIntegerField',
FIELD_TYPE.SHORT: 'IntegerField',
FIELD_TYPE.STRING: 'CharField',
FIELD_TYPE.TIMESTAMP: 'DateTimeField',
Index: django/db/backends/mysql/creation.py
===================================================================
--- django/db/backends/mysql/creation.py (revision 5637)
+++ django/db/backends/mysql/creation.py (working copy)
@@ -15,6 +15,7 @@
'FloatField': 'double precision',
'ImageField': 'varchar(100)',
'IntegerField': 'integer',
+ 'BigIntegerField': 'bigint',
'IPAddressField': 'char(15)',
'ManyToManyField': None,
'NullBooleanField': 'bool',
Index: django/db/backends/oracle/creation.py
===================================================================
--- django/db/backends/oracle/creation.py (revision 5637)
+++ django/db/backends/oracle/creation.py (working copy)
@@ -18,6 +18,7 @@
'FloatField': 'DOUBLE PRECISION',
'ImageField': 'NVARCHAR2(100)',
'IntegerField': 'NUMBER(11)',
+ 'BigIntegerField': 'NUMBER(19)',
'IPAddressField': 'VARCHAR2(15)',
'ManyToManyField': None,
'NullBooleanField': 'NUMBER(1) CHECK ((%(column)s IN (0,1)) OR (%(column)s IS NULL))',
Index: django/contrib/admin/views/doc.py
===================================================================
--- django/contrib/admin/views/doc.py (revision 5637)
+++ django/contrib/admin/views/doc.py (working copy)
@@ -303,6 +303,7 @@
'ForeignKey' : _('Integer'),
'ImageField' : _('File path'),
'IntegerField' : _('Integer'),
+ 'BigIntegerField' : _('Integer'),
'IPAddressField' : _('IP address'),
'ManyToManyField' : '',
'NullBooleanField' : _('Boolean (Either True, False or None)'),
Index: docs/model-api.txt
===================================================================
--- docs/model-api.txt (revision 5637)
+++ docs/model-api.txt (working copy)
@@ -126,6 +126,16 @@
automatically be added to your model if you don't specify otherwise. See
`Automatic primary key fields`_.
+``BigIntegerField``
+~~~~~~~~~~~~~~~~
+
+A big integer.
+
+The admin represents this as an ``<input type="text">`` (a single-line input).
+
+A 64 bit type like an ``IntegerField``, except that it fits numbers from
+-9223372036854775808 to 9223372036854775807
+
``BooleanField``
~~~~~~~~~~~~~~~~
