On 1/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
i started reimplementing my old manipulators code using newforms. Can u
guys give me some feedback on my usage of it?
What i wrote seems to me a lot of code for a 3 field form (even though
part of the bloat is due to date formatting)
Here's the code:
http://dpaste.com/hold/4382/
* Take advantage of AcademicYearForm.clean_data rather than parsing
the date fields yourself.
* There's no reason to do request.POST.copy().
* At the end of add_academic_year(), if it's successful, you should
redirect rather than returning the output of change_academic_year().
Always redirect after doing a request.POST, so that people who use the
back button don't retrigger the POST. This is not strictly a Django
thing; it's a Web development best practice.
In short:
def add_academic_year(request, info_msg=""):
if request.method == "POST":
form = AcademicYearForm(request.POST)
if form.is_valid():
ay = AcademicYear(**form.clean_data)
ay.save()
return HttpResponseRedirect('/url/to/change/page/')
else:
context = {'form': form, 'error_msg': "Please correct the
error(s) below"}
else:
context = {'form': AcademicYearForm()}
return render_to_response('academic_year.html', context)
You can also just use form_for_model, like so:
def add_academic_year(request, info_msg=""):
AcademicYearForm = form_for_model(AcademicYear)
if request.method == "POST":
form = AcademicYearForm(request.POST)
if form.is_valid():
ay = form.create()
return HttpResponseRedirect('/url/to/change/page/')
else:
context = {'form': form, 'error_msg': "Please correct the
error(s) below"}
else:
context = {'form': AcademicYearForm()}
return render_to_response('academic_year.html', context)
Adrian
--
Adrian Holovaty
holovaty.com | djangoproject.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django
users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---
