On donderdag 12 juli 2018 17:13:52 CEST Carlo Ascani wrote: > Il giorno gio 12 lug 2018 alle ore 16:44 Melvyn Sopacua > > <m.r.sopa...@gmail.com> ha scritto: > > First and foremost: awesome job. > > Thank you! > > > On donderdag 12 juli 2018 14:38:16 CEST Carlo Ascani wrote: > > > More details, if interested: > > > https://gitlab.com/2pxsolidblack/django-marple > > > > Your requirements.txt is a straight dump of pip freeze, including the `-e > > .`. That's not maintainable. > > mmm that requirements.txt is needed only for the demo project, > I suppose I could leave that out from the package...?
It's convention that requirements.txt is for the project. You could leave it out, or you could rename it to requirements-demo.txt so it's clear what it's for. Would also make setting up "my own demo" easier. > > I would worry about scaling: it's rather large in setup, so if for > > instance I would load bootstrap 4's scss, would this be a gigantic long > > page and menu? > That's an amazing feedback, will work on that, thank you! Related: Normally, I setup: scss/bootstrap.scss scss/bootstrap/variables.scss scss/bootstrap/color- variables.scss and maybe a few others that override the standard bootstrap settings and reference the package files in node_modules/ for the originals. I wouldn't need documentation on the original bootstrap files, in fact, I'd like my style guide to show only the files in scss/* not references in those files to locations outside of it. Maybe a little more complex so a long term goal for you :) -- Melvyn Sopacua -- You received this message because you are subscribed to the Google Groups "Django users" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscr...@googlegroups.com. To post to this group, send email to django-users@googlegroups.com. Visit this group at https://groups.google.com/group/django-users. To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/6425602.xWjK9ymFqQ%40fritzbook. For more options, visit https://groups.google.com/d/optout.
