I think your patch will do the trick, but maybe the problem should be
solved in the "source" of the problem.
Instead of removing empty IN's, it would be better if they don't show
up at all.
I tried a fix myself but it didn't worked:
django/db/models/query.py
# ...
def get_where_clause(lookup_type, table_prefix, field_name, value):
# ...
if lookup_type == 'in':
# Original
# return '%s%s IN (%s)' % (table_prefix, field_name,
','.join(['%s' for v in value]))
# My attempt
return ( value and ( '%s%s IN (%s)' % (table_prefix,
field_name, ','.join(['%s' for v in value])) ) ) or ''
# ...
Another problem may appear when using 'exclude', if the filter IN
returns an empty string, we can end up with an empty 'NOT ()'
condition, which breaks the SQL.
By now, I'm doing the check for the empty list in my view...
Regards.
Enrico
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this group, send email to django-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-users
-~----------~----~----~----~------~----~------~--~---
