Thanks, Łukasz. I looked into overriding that method too, but it seems like 
there should be a cleaner way. I almost feel like the ``ModelFormMixin`` 
should have an API similar to a ``ModelAdmin`` where one could override a 
``save_model()`` method on the subclass.

The ``form_valid()`` method does a lot of work that could be separted out 
(granted I don't know if more methods to override is a good thing!). The 
docs say that the method "saves the form instance, sets the current object 
for the view, and redirects to 
get_success_url()<http://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.edit.ModelFormMixin.get_success_url>
."[1]

This might just be semantics, but in my mind the validation of the form and 
the saving of the form should be separated. Let's see if anybody else has 
some input and if not then I will bring this over to django-developers 
and/or IRC.

[1] 
http://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.edit.ModelFormMixin.form_valid

Thanks,
Justin

-- 
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to django-us...@googlegroups.com.
To unsubscribe from this group, send email to 
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en.

Reply via email to