Hi again, I've had a read over your blog tutorial and have the following suggestions:
1) Make it PEP-8 (http://www.python.org/dev/peps/pep-0008/) compliant - it's a lot easier to read. 2) Except only the error that might occur in the paginatior example. Bare excepts are BAD. 3) Maybe consider enabling the context processor that adds the current user to the context 4) Consider using @login_required since all your views will break for logged out users 5) Consider using {% url %} instead of hard-coding your URLs 6) It isn't necessary to coerce the pk to an int as Django takes care of it in: Post.objects.get(pk=int(pk)) 7) I think the naming of variables in the add_comment view are confusing. The comment object is given a single letter name "c", but the comment form is confusingly given the name "comment". I'd suggest using more descriptive names, 8) In the same section you assume that the POST data will always have the key. Either use form validation here or allow for the POST to have missing data. 9) The mkmonth_list could largely be taken care of by the builtin calendar module Hope you find this helpful. Euan -- You received this message because you are subscribed to the Google Groups "Django users" group. To post to this group, send email to django-us...@googlegroups.com. To unsubscribe from this group, send email to django-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-users?hl=en.
