#36300: request.META["HTTP_" + self.header] in RemoteUserMiddleware __acall__ 
does
not sound correct
-------------------------------+------------------------------------
     Reporter:  Jan Pazdziora  |                    Owner:  (none)
         Type:  Bug            |                   Status:  new
    Component:  contrib.auth   |                  Version:  5.2
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Jacob Walls):

 * resolution:  needsinfo =>
 * stage:  Unreviewed => Accepted
 * status:  closed => new
 * type:  Uncategorized => Bug

Comment:

 Replying to [ticket:36300 Jan Pazdziora]:
 > This also shows that there don't seem tests covering the
 `RemoteUserMiddleware`, or the problem would have been caught.

 As developed in ticket:37025#comment:19, this is essentially right -- we
 had tests, but they were written incorrectly.

 It's a regression in 50f89ae850f6b4e35819fe725a08c7e579bfd099 with respect
 to custom headers. (The effort to support the default header under ASGI
 changed the semantic for custom headers.)

 I repurposed #37025 to clean up the tests, which should show the problem
 more clearly. I'll put up a fix.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36300#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019de47330fd-28dd75a9-e6cf-4a74-8df8-fffb5d768338-000000%40eu-central-1.amazonses.com.

Reply via email to