#37075: `OPTIONS["pool"]["check"]` cannot be set: the PostgreSQL backend always
passes `check=` to `psycopg_pool.ConnectionPool`, then unpacks
`**pool_options` on top, raising `TypeError`.
-------------------------------------+-------------------------------------
Reporter: Raoni Timo de | Owner: Raoni
Castro Cambiaghi | Timo de Castro Cambiaghi
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: postgresql psycopg | Triage Stage: Ready for
pool | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls <jacobtylerwalls@…>):
* resolution: => fixed
* status: assigned => closed
Comment:
In [changeset:"9f790ef1a0f356cf6342b5d57bbaeac35aed0d9f" 9f790ef]:
{{{#!CommitTicketReference repository=""
revision="9f790ef1a0f356cf6342b5d57bbaeac35aed0d9f"
Fixed #37075 -- Allowed overriding the PostgreSQL pool's "check" callable.
Setting "check" in OPTIONS["pool"] previously raised TypeError because the
PostgreSQL backend always passed check= to ConnectionPool() and unpacked
**pool_options on top, regardless of CONN_HEALTH_CHECKS. The user's
callable
now takes precedence via setdefault(); pool_options is copied first to
avoid
mutating the user's settings dict.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/37075#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019de0ceb22a-ad675865-2c05-4184-897d-ecbd1de96329-000000%40eu-central-1.amazonses.com.
