#37064: SimpleTestCase._remove_databases_failures() crashes on un-wrapped
connection methods
-------------------------------------+-------------------------------------
Reporter: Rio Weber | Owner: (none)
Type: Bug | Status: new
Component: Testing framework | Version: 6.0
Severity: Normal | Resolution:
Keywords: testcase, | Triage Stage:
databases, multi-db, regression | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Rio Weber):
so i looked a closer at it, obviously this isn't a security hole or
anything but i thought maybe you could leverage this make the pipleines
fail but report a pass, nope.
The teardown crash currently errors as hard non-silent failure but....
the defensive isinstance guard turns it into a clean teardow so still
worth it.
i built a `TransactionTestCase` that swaps `connection.cursor` in `setUp`
call a one function from a 2 method module and ran `coverage run manage.py
test` to see if would corrupt the coverage
The only way to use this bug to ship bad code would be to have a ci that
ignores exit codes and ignores errors > 0 in junit xml
still worth fixing though
--
Ticket URL: <https://code.djangoproject.com/ticket/37064#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019dc2befe3c-72c2df5e-e0ea-43d2-975d-edc0d130a4fb-000000%40eu-central-1.amazonses.com.
