#37046: PR Quality check may need to account for ready for check-in
--------------------------------+-----------------------------------------
Reporter: Tim Schilling | Type: Bug
Status: new | Component: Uncategorized
Version: dev | Severity: Normal
Keywords: GitHub Actions | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+-----------------------------------------
This is in reference to
[https://github.com/django/django/pull/21041#issuecomment-4272913765 PR
21041]
I reviewed @Afenomamy's PR and it looks ready to go. According to the
[https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#ready-for-checkin contribution docs], I'm supposed to mark it as
ready for check-in. I did so, but then it was flagged by the bot.
Reviewing the code for
[https://github.com/django/django/blob/main/scripts/pr_quality/check_pr.py
check_pr.py], there isn't an exception for this state. I suspect there
should be.
--
Ticket URL: <https://code.djangoproject.com/ticket/37046>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019da04fe511-c0fa3c94-ba7a-4617-bd43-a3f8b658c273-000000%40eu-central-1.amazonses.com.
