#37029: change_list.html: Broken markup inside {% block pagination %}
-------------------------------------+-------------------------------------
     Reporter:  Oganes Gambaryan     |                     Type:  Bug
       Status:  new                  |                Component:
                                     |  contrib.admin
      Version:  dev                  |                 Severity:  Normal
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
 {{{contrib/admin/templates/admin/change_list.html}}}:
 * The layout is fine without overriding the {{{pagination}}} block.
 * The layout will be broken if {{{pagination}}} block is overridden by
 child templates.

 The fix below:
 {{{
 diff --git a/django/contrib/admin/templates/admin/change_list.html
 b/django/contrib/admin/templates/admin/change_list.html
 index 78eef88294..3b1aa04615 100644
 --- a/django/contrib/admin/templates/admin/change_list.html
 +++ b/django/contrib/admin/templates/admin/change_list.html
 @@ -92,8 +92,8 @@
            <div class="changelist-footer">
            {% pagination cl %}
            {% if cl.formset and cl.result_count %}<input type="submit"
 name="_save" class="default" value="{% translate 'Save' %}">{% endif %}
 -          {% endblock %}
            </div>
 +          {% endblock %}
            </form>
          </div>
        </div>
 }}}
-- 
Ticket URL: <https://code.djangoproject.com/ticket/37029>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019d7a385fff-ac4c8b32-c9b1-4119-a440-528d48d9db26-000000%40eu-central-1.amazonses.com.

Reply via email to