#36988: Limitation of supported GeoIP databases is too tight
------------------------+---------------------------------------
Reporter: rami | Owner: SnippyCodes
Type: Bug | Status: assigned
Component: GIS | Version: 6.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------+---------------------------------------
Comment (by SnippyCodes):
Thank you for the incredible deep dive, @PhilS! Tracing this back to the
regressions introduced in #35100 makes perfect sense.
Your proposed solution is much cleaner than adding new settings. Trusting
the explicit country/city kwargs (or GEOIP_COUNTRY/GEOIP_CITY settings) to
bypass the strict SUPPORTED_DATABASE_TYPES check is an elegant, backward-
compatible approach. The underlying geoip2 library will still naturally
catch any invalid file formats.
I am going to pivot the PR to implement your exact algorithm. I will
update the GeoIP2 initialization logic to trust the explicit routing and
only use SUPPORTED_DATABASE_TYPES as a fallback. I'll push an updated
patch shortly!
--
Ticket URL: <https://code.djangoproject.com/ticket/36988#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019d0e947fcf-212a2cc7-85cd-4f15-a441-814d55d89bec-000000%40eu-central-1.amazonses.com.
