#36098: TypeError: object of type 'IPv6Address' has no len() when running tests
with GeoDjango
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: GIS | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Unreviewed => Accepted
Comment:
Sorry, I've notice the ticket when I had a patch ready. Feel-free to close
it, [https://github.com/django/django/pull/19047 PR].
We have two issues here:
- first `GeoIP2._query()` unnecessarily calls `validate_ipv46_address` for
always valid `query`,
- second `validate_ipv46_address()` and `validate_ipv6_address()` crash on
`ipaddress.IPv6Address` instances.
I know that calling `validate_ipv46_address()`/`validate_ipv6_address()`
is pointless, but it worked for years so I'd fix it.
--
Ticket URL: <https://code.djangoproject.com/ticket/36098#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019466e4e18c-12a430f7-59b5-4aa2-acee-38e0d28ef2f1-000000%40eu-central-1.amazonses.com.
