#34022: admin:logout fails to log out non-staff users
-------------------------------+--------------------------------------
Reporter: Jan Pazdziora | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Jan Pazdziora):
* status: closed => new
* resolution: wontfix =>
Comment:
Well, the change is backward incompatible in the sense that it changes
behaviour, yes. But it my mind it fixes a problem which was introduced by
some refactoring which changed behaviour for non-staff users by mistake.
In the https://github.com/django/django/pull/16073#issuecomment-1250690063
comment I've now shown an alternative approach which would only cater to
the non-staff case and as shown by the unmodified
`test_client_logout_url_can_be_used_to_login` (just renamed to
`test_logout_if_not_authenticated` to make its purpose more explicit), the
behaviour for the unauthenticated case does not change.
Let me reopen this ticket to have some more discussion about the non-staff
case which as far as I can see is currently not captured by any tests so
that behaviour seems to be undefined.
--
Ticket URL: <https://code.djangoproject.com/ticket/34022#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018354cc2751-20e48496-c108-48ab-89ff-4d6fad251007-000000%40eu-central-1.amazonses.com.