#33346: assertFormsetError() crashes on formset named "form".
-------------------------------------+-------------------------------------
Reporter: OutOfFocus4 | Owner: Baptiste
| Mispelon
Type: Bug | Status: assigned
Component: Testing framework | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):
* owner: nobody => Baptiste Mispelon
* status: new => assigned
Comment:
Replying to [comment:4 Mariusz Felisiak]:
> What do you think about skipping context values that are not a `FormSet`
instance? or don't have the `forms` attribute. This should be backward
compatible.
I haven't thought it through completely, but my gut feeling is that your
proposed fix would work for the reported regression but there might still
be corner cases that could fail. But those corner cases might have already
been broken so it's probably ok.
I'll start working on a PR, it'll be easier for me to think it through
with some concrete examples.
Replying to [comment:4 Mariusz Felisiak]:
> We cannot change or deprecate an existing and documented API as a part
of patch which is intended for backport. This can be discussed separately.
Personally, I like the idea.
Agreed, I'll open a separate ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/33346#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.d6b0a306ac8afed22ae66e8fbc7e4f7f%40djangoproject.com.
