#33140: order of checks
-----------------------------------------+------------------------
Reporter: David Szotten | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
https://github.com/django/django/pull/8967 changes the checks registry to
use sets instead of lists. i may be missing it, but i can't see a ticket
reference or any reason for the change
i just had a bug where the behaviour of a generated file (happened to be
by https://github.com/adenh93/django-typomatic) depends on collecting
classes, which in turn depends on the import order of files in my project
i had two different invocations get different orderings of checks causing
different import orders
could we consider switching back to lists? or e.g. using `sorted` instead
of `list` in `get_checks`
https://github.com/django/django/blob/8036b53de61f16098a2f22c50621987182bdfaed/django/core/checks/registry.py#L96
--
Ticket URL: <https://code.djangoproject.com/ticket/33140>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/055.2953a9b5a4a8f39fdfe6a4c843f7f9c1%40djangoproject.com.
