#33077: Wrong URL generated by get_admin_url for readonly field in custom Admin
Site
---------------------------------+------------------------------------
     Reporter:  Ken Whitesell    |                    Owner:  nobody
         Type:  Bug              |                   Status:  new
    Component:  contrib.admin    |                  Version:  3.2
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Hey Ken, yes seems right. Good spot.

 Looks like this should have been part of
 b79088306513d5ed76d31ac40ab3c15f858946ea  for #31181 (which was Django
 3.2)
 
[https://github.com/django/django/commit/b79088306513d5ed76d31ac40ab3c15f858946ea
 #diff-07734f3e730920ea3922e6de9cb783825f009817b53e16ece8c3c2e3fdb41e40R199
 here].

 > However, I don't know if there are any side effects and I have not yet
 run the full suite of tests on this. Mostly looking for feedback whether
 I'm on the right track.

 I ran your suggestion against most of the ''usual suspects'' `admin_*`
 tests without issue so...

 Would you like to prepare a patch? Looks like setting up the test case is
 the most of it...

 Thanks!

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33077#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.68c476ee7be38d968156525886ca12be%40djangoproject.com.

Reply via email to