#32962: Consolidate string concatenations in
BaseDatabaseSchemaEditor.column_sql()
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: Chris Jerdonek
Jerdonek |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: dev
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently,
[https://github.com/django/django/blob/20226fcd461670334646f78a0c4d133e439b12b2/django/db/backends/base/schema.py#L209
BaseDatabaseSchemaEditor.column_sql()] builds up a `sql` string by
repeated concatenations with itself. I noticed this could be combined into
a single `' '.join(...)` if an iterator that yields `sql` parts is
factored out. This will eliminate the need to create temporary
intermediate strings and should improve readability.
--
Ticket URL: <https://code.djangoproject.com/ticket/32962>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.caef678ba19dd619c105b3e40a1adfc1%40djangoproject.com.
