#32913: test_glob inside utils_tests.test_autoreload.WatchmanReloaderTests is
flaky
--------------------------------------+------------------------------------
Reporter: Abhyudai | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Nick Pope):
* status: closed => new
* has_patch: 0 => 1
* resolution: needsinfo =>
* stage: Unreviewed => Accepted
Comment:
Re-opening this as I've been experiencing this same issue.
The issue is that `WatchmanReloaderTests.setUp()` sets
`self.reloader.client_timeout = 0.1` to speed up the tests.
It seems that this is too low as at 0.1s the following fail consistently
for me on every execution:
{{{
ERROR: test_glob (utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_glob_recursive
(utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_multiple_globs
(utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_multiple_recursive_globs
(utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_nested_glob_recursive
(utils_tests.test_autoreload.WatchmanReloaderTests)
}}}
Changing to 0.2s the following fail consistently:
{{{
ERROR: test_glob (utils_tests.test_autoreload.WatchmanReloaderTests)
ERROR: test_glob_recursive
(utils_tests.test_autoreload.WatchmanReloaderTests)
}}}
Changing to 0.5s the following fail intermittently:
{{{
ERROR: test_glob (utils_tests.test_autoreload.WatchmanReloaderTests)
}}}
In the end I settled for 0.6s which seemed to work consistently. See
[https://github.com/django/django/pull/14660 PR].
Unfortunately, much like the tests for caching, I think we're going to
have to suffer longer running tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/32913#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.ec2fcd275e3f88eba26218e5b0953623%40djangoproject.com.
