#27079: Refactor LiveServerPort.test_port_bind() not to call setUpClass() twice
-----------------------------------+------------------------------------
     Reporter:  Chris Jerdonek     |                    Owner:  (none)
         Type:  Bug                |                   Status:  new
    Component:  Testing framework  |                  Version:  1.10
     Severity:  Normal             |               Resolution:
     Keywords:                     |             Triage Stage:  Accepted
    Has patch:  0                  |      Needs documentation:  0
  Needs tests:  0                  |  Patch needs improvement:  0
Easy pickings:  0                  |                    UI/UX:  0
-----------------------------------+------------------------------------

Comment (by Chris Jerdonek):

 > Chris, is it the case that the changes you referred to were undone in
 8c775391b78b2a4a2b57c5e89ed4888f36aada4b? Perhaps we could revert to the
 original issue title (and include the test that follows it)?

 Nice observation, Jacob. More specifically, it was done
 
[https://github.com/django/django/commit/8c775391b78b2a4a2b57c5e89ed4888f36aada4b
 #diff-
 c0d7a27759b0649539ed852dde69da3527fc718af1806dc28b93697d3dd0ceb4L212-R212
 in these lines] and below.

 Do you want to go ahead with what you suggest? It could also help to
 comment on that PR so the connection between the tickets is more
 noticeable.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/27079#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.232f1b26fc6c68c1070af13bd593cbcb%40djangoproject.com.

Reply via email to