#32771: Hardcoded _popup values should use IS_POPUP_VAR instead
------------------------------------------------+------------------------
Reporter: David Sanders | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
There's a handful of places in the codebase which hardcode the '_popup'
string rather than using the `IS_POPUP_VAR` constant. They should all use
`IS_POPUP_VAR` for consistency.
I've got a PR to fix all occurrences other than two cases in the admin
JavaScript, since there's not a clear fix there. Possible solutions for
JavaScript would be to add it into the base admin template and pull it
back out in the code that needs it, or hardcode it in a single spot in the
JavaScript on `window`. Neither solution feels great to me, so I'm kicking
the can down the road on the JavaScript occurrences.
--
Ticket URL: <https://code.djangoproject.com/ticket/32771>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/053.3c4de01dbf76ed294c2b81a597e13c1a%40djangoproject.com.
