#32733: DEFAULT_AUTO_FIELD feature leads `AbstractModel.check()` to fail with
AttributeError
-------------------------------------+-------------------------------------
Reporter: amureki | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Johannes Maron):
* cc: Johannes Maron (added)
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
It is arguable, whether if the checks need to work on an abstract class. I
also noticed that Django will raise an error since 3.2 if you try to
instantiate an abstract model.
Though, there is no place where checks are called on abstract models
inside an application, this does make unit testing harder.
With that in mind, maybe this is best classified as an optimization not a
bug, since no public API is broken, not does this affect the application
itself. However, since Django is a developer-friendly framework and comes
with an excellent test suite, I believe an improvement would be welcome by
many.
--
Ticket URL: <https://code.djangoproject.com/ticket/32733#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.32ff62a671bd8a926886e3067e9e8594%40djangoproject.com.
