#32584: OrderBy.as_sql() overwrites template, creating invalid syntax for
certain
database backends
-------------------------------------+-------------------------------------
Reporter: Tim Nyborg | Owner: nobody
Type: Uncategorized | Status: new
Component: Database layer | Version: 3.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: order_by, | Triage Stage:
nulls_first | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Nyborg):
Prior to this commit:
(https://github.com/django/django/commit/7286eaf681d497167cd7dc8b70ceebfcf5cd21ad),
a supplied template would not be overridden. I think that's the correct
approach - logic to add `nulls last` or `order by <expression> is null`
should only be applied to `self.template`, if `template` is null.
--
Ticket URL: <https://code.djangoproject.com/ticket/32584#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.20492280d67d32fe334b59d88aca3ba5%40djangoproject.com.
