#32526: Class based custom template filters seem to be broken since Django 2.0
-------------------------------------------+------------------------
Reporter: 884756834 | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
In Django 1.10, writing a custom template filter using a class used to
work:
{{{
#!div style="font-size: 80%"
Code highlighting:
{{{#!python
class MyCustomFilter(object):
__name__ = 'custom_filter'
def __call__(self, value):
if not isinstance(value, str):
return value
return MyHelperClass(value).do_stuff()
def custom_filter(value) = MyCustomFilter()
}}}
}}}
But in Django 2.2 (and likely from 2.0 to 3.1) this seems to raise an
error:
{{{django.template.exceptions.TemplateSyntaxError: "requires 2 arguments,
1 provided"}}}
I believe it is caused by the changes in one of, or both, these 2 commits:
https://github.com/django/django/commit/c2a1af883e18b93a77080650feb9e959536d51ca
https://github.com/django/django/commit/620e9dd31a2146d70de740f96a8cb9a6db054fc7
As a workaround, I've been able to rewrite it:
{{{
#!div style="font-size: 80%"
Code highlighting:
{{{#!python
def custom_filter(value):
if not isinstance(value, str):
return value
return MyHelperClass(value).do_stuff()
}}}
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32526>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.4ba2b8c10b300269ac3039d3b8f22cce%40djangoproject.com.
