#32480: Outdated docstring in permission_denied() and redundant comments in
default
error pages.
--------------------------------------+------------------------------------
Reporter: BeryCZ | Owner: BeryCZ
Type: Cleanup/optimization | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* status: new => assigned
* cc: Claude Paroz (added)
* needs_better_patch: 0 => 1
* component: Uncategorized => Error reporting
* owner: nobody => BeryCZ
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Replying to [ticket:32480 BeryCZ]:
> **1)** the permission_denied() returns
> ...
> I suppose someone just forgot to read the whole code when making some
changes, so it might be better to use the same code to get the exception
message...?
That's not true, it was discussed in the original ticket #24733, see
[https://github.com/django/django/pull/4590#issuecomment-99842965
comments]. I don't see any reason to use the same special treatment for
403.
I agree with fixing comments and docstrings.
[https://github.com/django/django/pull/14024/ PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32480#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.8daa634af0fddbbc4384fdfaf5f55bbb%40djangoproject.com.
