#32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure
-------------------------------------+-------------------------------------
     Reporter:  Chris Jerdonek       |                    Owner:  Chris
                                     |  Jerdonek
         Type:  Bug                  |                   Status:  assigned
    Component:  Testing framework    |                  Version:  2.2
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
  LiveServerTestCase,setUpClass      |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Florian Apolloner):

 The cleanup precedes the commit that modified the settings by three years
 
(https://github.com/django/django/commit/17e661641ddaf8266e7430d83cfb2039abc55df7
 &
 
https://github.com/django/django/commit/73a610d2a81bc3bf2d3834786b2458bc85953ed0)
 so it is more than likely that this was just an oversight at the time.
 I'll give the PR a review in a second.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32437#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fd8e7a402ca79bfd38596a014d34056e%40djangoproject.com.

Reply via email to