#32191: Not RFC 6265 compliant cookies in contrib.messages.
----------------------------------+---------------------------------------
     Reporter:  Nico Giefing      |                    Owner:  Craig Smith
         Type:  Bug               |                   Status:  assigned
    Component:  contrib.messages  |                  Version:  3.1
     Severity:  Normal            |               Resolution:
     Keywords:  Cookie malformed  |             Triage Stage:  Accepted
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+---------------------------------------

Comment (by Craig Smith):

 Hi All, I've updated the PR with the `compress_b64encode` and
 `b64decode_decompress` methods extracted into the `django.core.signing`
 module. I could use some help with the names, should they be `compress`
 and `decompress` or mention the b64 encoding as in the current PR?

 Also, the encoding from string to bytestring and back again needs some
 thinking. If the compress/decompress methods are going to be used by
 client code (as indeed they might be to extract raw messages from
 `req.cookies['messages'].value`) then getting `decompress` to return a
 string instead of a bytestring would be better. And `compress` should be
 modified to accept a string. That will probably be my next step when I get
 back to this during the week.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32191#comment:18>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.de7544e148679821808896030816d2f2%40djangoproject.com.

Reply via email to