#32008: sanitize_address() can add newlines in a header that
django.core.mail.EmailMessage will refuse.
-------------------------------------+-------------------------------------
Reporter: Pierre-Elliott | Owner: nobody
Bécue |
Type: Bug | Status: closed
Component: Core (Mail) | Version: 2.2
Severity: Normal | Resolution: needsinfo
Keywords: mail | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Pierre-Elliott Bécue):
Hi,
{{{
In [1]: from django.core.mail.message import sanitize_address
In [2]: from django.core.mail import EmailMessage
In [3]: msg = EmailMessage(from_email=sanitize_address("Pierre-Elliott
Charles Maxime Antoine Bécue via nm.debian.org <[email protected]>",
'utf-8'), subject="Test", body="", to
...: =[sanitize_address("Pierre-Elliott Charles Maxime Antoine Bécue
via nm.debian.org <[email protected]>", 'utf-8'),])
In [4]: msg.send()
---------------------------------------------------------------------------
BadHeaderError Traceback (most recent call
last)
<ipython-input-13-e80ddd8be11c> in <module>()
----> 1 msg.send()
/usr/lib/python3/dist-packages/django/core/mail/message.py in send(self,
fail_silently)
304 # send to.
305 return 0
--> 306 return
self.get_connection(fail_silently).send_messages([self])
307
308 def attach(self, filename=None, content=None, mimetype=None):
/usr/lib/python3/dist-packages/django/core/mail/backends/smtp.py in
send_messages(self, email_messages)
108 num_sent = 0
109 for message in email_messages:
--> 110 sent = self._send(message)
111 if sent:
112 num_sent += 1
/usr/lib/python3/dist-packages/django/core/mail/backends/smtp.py in
_send(self, email_message)
122 from_email = sanitize_address(email_message.from_email,
encoding)
123 recipients = [sanitize_address(addr, encoding) for addr in
email_message.recipients()]
--> 124 message = email_message.message()
125 try:
126 self.connection.sendmail(from_email, recipients,
message.as_bytes(linesep='\r\n'))
/usr/lib/python3/dist-packages/django/core/mail/message.py in
message(self)
269 msg = self._create_message(msg)
270 msg['Subject'] = self.subject
--> 271 msg['From'] = self.extra_headers.get('From',
self.from_email)
272 self._set_list_header_if_not_empty(msg, 'To', self.to)
273 self._set_list_header_if_not_empty(msg, 'Cc', self.cc)
/usr/lib/python3/dist-packages/django/core/mail/message.py in
__setitem__(self, name, val)
182
183 def __setitem__(self, name, val):
--> 184 name, val = forbid_multi_line_headers(name, val,
self.encoding)
185 MIMEText.__setitem__(self, name, val)
186
/usr/lib/python3/dist-packages/django/core/mail/message.py in
forbid_multi_line_headers(name, val, encoding)
60 val = str(val) # val may be lazy
61 if '\n' in val or '\r' in val:
---> 62 raise BadHeaderError("Header values can't contain newlines
(got %r for header %r)" % (val, name))
63 try:
64 val.encode('ascii')
BadHeaderError: Header values can't contain newlines (got '=?utf-8?q
?Pierre-Elliott_Charles_Maxime_Antoine_B=C3=A9cue_via_nm=2Edebian?=\n
=?utf-8?q?=2Eorg?= <[email protected]>'
for header 'From')
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32008#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/061.3a39dcfb589909f6c1176f57fc1374d7%40djangoproject.com.
