#31913: PasswordResetConfirmView results in NoReverseMarch
---------------------------------+--------------------------------------
     Reporter:  Bruno Vermeulen  |                    Owner:  nobody
         Type:  Bug              |                   Status:  closed
    Component:  contrib.auth     |                  Version:  3.1
     Severity:  Normal           |               Resolution:  invalid
     Keywords:                   |             Triage Stage:  Unreviewed
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+--------------------------------------

Comment (by Phil Gyford):

 Replying to [comment:1 felixxm]:

 There's
 [https://github.com/django/django/blob/master/django/contrib/auth/tokens.py#L76
 a comment] on `PasswordResetTokenGenerator._make_token_with_timestamp()`
 that reads:

 {{{
 # Limit to 20 characters to shorten the URL.
 }}}

 I assume this used to be the case but, given the URL rule was changed to
 be more forgiving, that it's no longer true. It did confuse me when I was
 trying to figure out why my own URL rule was no longer matching, like the
 reporter's.

 I assume the comment should be changed (is the length 32 characters now?).
 Sorry, I'm not sure if this should be a new Ticket (I'm new here).

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31913#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6862a3aba2a6217df2b6b0b51fe6f002%40djangoproject.com.

Reply via email to