#31720: Better documentation and defaults for BoolOr and BoolAnd
-------------------------------------+-------------------------------------
Reporter: Alex Scott | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 3.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Alex Scott):
Thanks Simon for the quick response. I'm a bit of a n00b and have never
really contributed a PR to an open source project but maybe this could be
the first. Do you think setting the default is all that needs to be done?
I can try to take a look over this next week (and read about how to
contribute) and let you know if I think I'm capable.
Replying to [comment:1 Simon Charette]:
> A patch for both documentation and explicit `output_field` for `BoolOr`
and `BoolAnd` would be welcome. The issue you're experiencing here is
likely due to the fact `Q` and `WhereNode` are marked `conditional=True`
but don't set `output_field = models.BooleanField()` and thus the default
behavior of `Expression._resolve_output_field` cannot be leveraged.
>
> Are you interested in submitting a PR with these improvements?
--
Ticket URL: <https://code.djangoproject.com/ticket/31720#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.58789562fcbf045137ae5a6463acb460%40djangoproject.com.
