#31698: Remove DatabaseOperations.autoinc_sql()
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: | Status: closed
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
At least [https://github.com/maxirobaina/django-firebird django-firebird]
is still active and linked from our documentation. I suggested to remove
it from our documentation since it hasn't had a release since Django 1.11
but [https://github.com/django/django/pull/12948#issuecomment-632150457
that wasn't accepted].
I don't really care about the fate of this issue but I don't think the
code is adding much maintenance burden to Django and if there are at least
two databases that use this feature, it seems there could be others (I
stopped my github code search after these two hits in as many minutes). It
seems easier to update this logic (like adding 'SmallAutoField') once in
Django, rather than requiring each backend to make that update (although
firebird is currently [https://github.com/maxirobaina/django-
firebird/blob/80a4ea8c80c967bd9a4738d49abdd80f508014b0/firebird/schema.py#L743-L747
copying enough code] in its SchemaEditor that this argument doesn't
apply).
I guess having that code in Django is at least helpful in the sense that
it calls out "if your database has this behavior, do it here."
--
Ticket URL: <https://code.djangoproject.com/ticket/31698#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.7793509d64026ca5c2c43b602e9f0c0c%40djangoproject.com.
