#31443: LoginRequiredMixin/AccessMixin bug with off-site LOGIN_URL
----------------------------------------+--------------------------------
               Reporter:  minusf        |          Owner:  nobody
                   Type:  Bug           |         Status:  new
              Component:  contrib.auth  |        Version:  3.0
               Severity:  Normal        |       Keywords:  login required
           Triage Stage:  Unreviewed    |      Has patch:  1
    Needs documentation:  0             |    Needs tests:  0
Patch needs improvement:  0             |  Easy pickings:  1
                  UI/UX:  0             |
----------------------------------------+--------------------------------
 The class based "login required" mechanism lost a bit of functionality
 compared to its decorator sister: it always sends
 `request.get_full_path()`, even for off-site `LOGIN_URL`s.

 https://github.com/django/django/blob/master/django/contrib/auth/mixins.py#L44
 vs
 
https://github.com/django/django/blob/master/django/contrib/auth/decorators.py#L22-L33

 The patch is trivial and i will make the PR after i'll know the ticket
 number.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31443>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.fa2cb655dca411fd464b6454888f6141%40djangoproject.com.

Reply via email to