#31358: Increase default password salt size in BasePasswordHasher.
--------------------------------------+------------------------------------
     Reporter:  Jon Moroney           |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Utilities             |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by Jon Moroney):

 No worries on the late reply. I know the world is a bit hectic right now
 :)

 I've gone ahead and made a PR which adds an empty decode function to the
 base password hasher as well as a simple implementation to the pbkdf2
 hasher.

 https://github.com/django/django/pull/12675

 I think it's probably better to require the decode function rather than
 having to deal with if it exists or not and update salt lengths only if
 the function does exist. I feel that having this be optional will only
 lead to more headaches down the line.

 Let me know how you feel about this and I can update the PR to include
 similar `decode()`s for the other hashers included.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31358#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ed13900d3be0c2f040957178293824eb%40djangoproject.com.

Reply via email to