#31353: Improved performance of admin changeform_view.
------------------------------------------------+------------------------
Reporter: Hasan Ramezani | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
There is a check for formset and form validation in
[https://github.com/django/django/blob/eb77e80de01e658541d4fcc3b0b38783ce4e6a7e/django/contrib/admin/options.py#L1566
ModelAdmin._changeform_view]
`if all_valid(formsets) and form_validated:`
We can change the order of checks to prevent validation of all formsets
when `form_validated=Flase`:
`if form_validated and all_valid(formsets):`
Here is the [https://github.com/django/django/pull/12483 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/31353>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.69229ab41b6c9676e823cbb2ac150d5a%40djangoproject.com.
