#31255: Migrations create a redundant RemoveField operation when deleting 2
models
with related fields.
-------------------------------------+-------------------------------------
Reporter: Panagis | Owner: Rohit Jha
Alisandratos |
Type: | Status: assigned
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: migration,optimizer | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
> After going through this, I have built on top of this and further fixed
the ManyToManyField removal test cases and added another test case for
this ticket as well
Nice, I think `test_non_cyclical_models_removals` already covers this
ticket's case though; no need to add another one at the auto-detector
level IMO.
> How should I create the PR, given that I have built on top of your
existing code?
Assuming you pushed your work to a branch that includes the above commit
it should be the same process as opening any other PR. I'd leave the two
commits separated so they can be reorganized by the mergers as they deem
the most appropriate.
--
Ticket URL: <https://code.djangoproject.com/ticket/31255#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.22823ac55a300423f20b361733847438%40djangoproject.com.
