#31314: makemessages doesn't provide feedback when no locale is specified
-------------------------------------+-------------------------------------
Reporter: cmackenziek | Owner: nobody
Type: Bug | Status: new
Component: Core (Management | Version: 3.0
commands) |
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by cmackenziek:
Old description:
> makemessages requires that one of three flags be passed to specify
> locales for message building: `--locale` to explicitly specify locales,
> `--exclude` to specify locales to exclude, or `--all` to build message
> files for all locales.
>
> When non of these flags are present, the command doesn't show any errors
> for the user. According to the source code, it should raise
> `CommandError`, but that never happens because of a bug in an `if`
> statement that checks if a locale has been specified.
>
> I've already fixed this in my fork and will submit a small PR.
New description:
makemessages requires that one of three flags be passed to specify locales
for message building: `--locale` to explicitly specify locales,
`--exclude` to specify locales to exclude, or `--all` to build message
files for all locales.
When non of these flags are present, the command doesn't show any errors
for the user. According to the source code, it should raise
`CommandError`, but that never happens because of a bug in an `if`
statement that checks if a locale has been specified.
I've already fixed this in my fork and have submitted a small PR.
https://github.com/django/django/pull/12503
Please point out if there are any other necessary steps to move this
forward. Thanks!
--
--
Ticket URL: <https://code.djangoproject.com/ticket/31314#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.14f79c5aa4715732b65e9b56203619c5%40djangoproject.com.
