#31189: django.contrib.auth: Password field help text generates invalid html
-------------------------------------+-------------------------------------
     Reporter:  Marc Nieper-         |                    Owner:  nobody
  Wißkirchen                         |
         Type:  Bug                  |                   Status:  new
    Component:  contrib.auth         |                  Version:  3.0
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Description changed by Marc Nieper-Wißkirchen:

Old description:

> The help text for the password field of, say, the UserCreationForm, is
> generated here:
> https://github.com/django/django/blob/master/django/contrib/auth/password_validation.py#L78
> and is an html list. The form methods, `as_table' and `as_p', however,
> wrap the help text into a span tag. In the resulting rendered HTML, there
> will thus be a ul tag inside a span tag, which is invalid html.
>
> To solve this problem, the span tag needs to be a div.

New description:

 The help text for the password field of, say, the UserCreationForm, is
 generated here:
 
https://github.com/django/django/blob/master/django/contrib/auth/password_validation.py#L78
 and is an html list. The form methods, `as_table' and `as_p', however,
 wrap the help text into a span tag. In the resulting rendered HTML, there
 will thus be a ul tag inside a span tag, which is invalid html.

 To solve this problem, the span tag needs at least to be a div. But then
 there is the problem that `as_p' renders everything inside a paragraph,
 which also cannot take an html list, only phrasing content.

--

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31189#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.982bdd4439529cf80837c302a30a6cc3%40djangoproject.com.

Reply via email to