#29138: Add ModelAdmin.autocomplete_fields support for ForeignKeys that use
to_field
-------------------------------+------------------------------------
     Reporter:  Jonathan Nye   |                    Owner:  schwtyl
         Type:  Bug            |                   Status:  assigned
    Component:  contrib.admin  |                  Version:  2.0
     Severity:  Normal         |               Resolution:
     Keywords:  autocomplete   |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  1
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by Johannes Hoppe):

 * needs_better_patch:  0 => 1


Comment:

 Hi schwtyl,

 thanks for your commitment. I must admit, I did push this issue aside a
 bit in favor of some other patches I have been working on.

 Sadly, you did base your work on GH@10494 not on GH@11026, therefore my
 critique stays the same. It will only solve this issue but make it harder
 to solve #29138 which is equally important.

 Might I also suggest next time, to comment on the ticket first, before
 fixing someone else's patch. I might save you some trouble.

 Best
 -Joe

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29138#comment:18>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8c96d26377cab875670ffaf606cdd797%40djangoproject.com.

Reply via email to