#30858: Ambiguous phrasing in the Error Reporting documentation
-------------------------------------+-------------------------------------
     Reporter:  ForgottenLords       |                    Owner:  Carlton
         Type:                       |  Gibson
  Cleanup/optimization               |                   Status:  assigned
    Component:  Documentation        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  Error Reporting,     |             Triage Stage:  Accepted
  Documentation                      |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 After a quick chat with Mariusz, looks like we'll take the PR. Thanks for
 the report!

 > It may be worth expanding on the error handling to allow users to return
 'safe' 500 responses that will not be logged, and in fact Django does
 check for the _has_been_logged property already before logging the
 response, which we can set in our code already so perhaps just exposing
 that to the documentation in a little note would be useful to people who
 want to send 500 responses without sending emails might be sufficient.

 I don't think that adding this complication is worth the gain. Users
 already find logging complicated enough. Those in this particular case can
 look at `log_response()`, as you have done.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30858#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.933ba2349f0f6e57469579572ae7ca7d%40djangoproject.com.

Reply via email to