#30043: AdminURLFieldWidget incorrectly unquotes URLs e.g. containing %2F
-------------------------------------+-------------------------------------
Reporter: Brenton Partridge | Owner: Brady
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, urlfield, | Triage Stage: Accepted
smart_urlquote, url, quote |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Hi Brady.
Florian on the PR:
> I do not feel good about the special casing, also the tests seem rather
minimal. How long can a segment be? what happens if the segment contains
other special characters etc?
Taking the special casing first. At the DjangoCon sprints we were close to
thinking this might be intractable... because of the way `quote()` will
always double-escape... (memory slipping now). Can you re-construct the
analysis here that led to the idea to just handle the special case?
It may be that we have to say we can't solve it, but at least then we'll
see *why* your suggestion is as it is.
From there we can think about whether more test cases would be needed.
Thanks for the effort!
--
Ticket URL: <https://code.djangoproject.com/ticket/30043#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.cc625e864568e28e36f1ca66cf4061cf%40djangoproject.com.
