#30807: test_extract_file_permissions test fails when umask is set to 000.
-----------------------------------+------------------------------------
Reporter: Brady | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by Ad Timmering):
Having now read back the history of the previous tickets (#26494 and
#27628) a few thoughts:
`_copy_permissions` was introduced in #27628 to ensure files remain
readable by the owner so that files extracted from an archive remain
readable (and thus executable), even if they do not have those permissions
set within the archive.
It seems we have (at least) two options:
1. Rather than checking it has owner-read (`stat.S_IROTH`) we could do a
bit-wise OR to ensure owner-read on all extracted files
(which is what is happening now too, but in current state group & world
permissions are now set to OS default instead of what is set in the
archive)
2. Just fix the current test to not assume a umask of 2, but leaving
current permissions logic in place.
Any thoughts?
--
Ticket URL: <https://code.djangoproject.com/ticket/30807#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.9b70b373614f1dc12049eea0c5846a97%40djangoproject.com.
