#30651: __eq__ should return NotImplemented when equality cannot be checked.
-------------------------------------+-------------------------------------
Reporter: Elizabeth Uselton | Owner: Elizabeth
Type: | Uselton
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Elizabeth Uselton):
I've added a PR that only has a few of the classes changed, since at a
glance there are like 70 classes with `__eq__` overwritten, and I'd prefer
to get the high value `Model` change merged (people seem much more likely
to compare `Model` in tests than other classes) and get feedback on the
tests I added (whether they're in the right place, and whether I'd need to
add them for every `False` to `NotImplemented` change).
--
Ticket URL: <https://code.djangoproject.com/ticket/30651#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.c5d4e3d7d694f65cc44e299f21c8736b%40djangoproject.com.
